Skip to content

wxGUI/datacatalog: fix setting output vector/raster format #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented May 23, 2021

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI
  2. On the Data tab (page) choose from toolbar 'Select another import option' tool and invoke menu and choose 'Link external data' -> 'Set raster output format [r.external.out]'
  3. Choose Directory as Output type
  4. Choose e.g. GeoTIFF format
  5. Set Directory path e.g. /tmp
  6. Hit Ok button
  7. You get error message

Error message

wxgui_datacatalog_set_output_raster_format_error_message

Additional info

  1. 'Set raster output format [r.external.out]' dialog internally use v.external.out command instead of r.external.out and params args are incorrect
  2. Mapping output formats between dialog wx.Choice widget items (which use long format name) and command r.external.out or v.external.out (which use format abbreaviation) is incorrect . Simple e.g. 'Set raster output format [r.external.out]' dialog wx.Choice format type widget use for GeoTIFF format string 'GeoTIFF', but internall command r.external.out as format param argument accept for GeoTIFF format string arg 'GTiff' (check all format options r.external.out), the same is true for 'Set vector output format [v.external.out]' dialog.

@tmszi tmszi added bug Something isn't working GUI wxGUI related labels May 23, 2021
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me, I recommend giving it little bit of time before backport, just to make sure it doesn't impact things outside of r/v.external.out.

@tmszi tmszi merged commit aed1810 into OSGeo:master Jun 18, 2021
@tmszi tmszi deleted the wxgui-datacalog-fix-run-set-output-raster-vector-format branch June 18, 2021 05:18
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 18, 2021
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jun 19, 2021
@landam
Copy link
Member

landam commented Oct 7, 2021

Not easy to backport (conflicts). @petrasovaa What about removing backported_needed label.

@neteler neteler added this to the 8.0.1 milestone Dec 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
a0x8o added a commit to a0x8o/grass that referenced this pull request May 9, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request May 21, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 3, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 17, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 17, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 27, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jul 2, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jul 10, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jul 23, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jul 23, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Jul 31, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Aug 13, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Aug 23, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Sep 5, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Sep 5, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Sep 5, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Sep 5, 2024
wxGUI/datacatalog: fix setting output vector/raster format (OSGeo#1596)
a0x8o added a commit to a0x8o/grass that referenced this pull request Oct 16, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Oct 18, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Oct 21, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Oct 29, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Nov 11, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Nov 11, 2024
a0x8o added a commit to a0x8o/grass that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants