Skip to content

i.tasscap: utf-8 encoding for non-ASCII chars #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

HuidaeCho
Copy link
Member

@HuidaeCho HuidaeCho commented Jun 13, 2021

This PR addresses:

$ xgettext i.tasscap.py 
xgettext: Non-ASCII comment at or before i.tasscap.py:49.
          Please specify the source encoding through --from-code or through a comment
          as specified in http://www.python.org/peps/pep-0263.html.

@HuidaeCho HuidaeCho requested a review from neteler June 13, 2021 18:35
@nilason
Copy link
Contributor

nilason commented Jun 13, 2021

Why not use --from-code=UTF-8? I see no reason to start re-adding this coding line for no good reason, py3-files are by default (interpreted as) utf-8.

@nilason
Copy link
Contributor

nilason commented Jun 13, 2021

In case you it slipped your attention see #1461.

@neteler
Copy link
Member

neteler commented Jun 13, 2021

Why not use --from-code=UTF-8? I see no reason to start re-adding this coding line for no good reason, py3-files are by default (interpreted as) utf-8.

At time we have a compilation issue in the snapshot compilation log on grass.osgeo.org (Debian):
See: https://grass.osgeo.org/grass80/binary/linux/snapshot/build.log.txt

xgettext: Non-ASCII comment at or before ../scripts/i.tasscap/i.tasscap.py:49.
          Please specify the source encoding through --from-code or
through a comment
          as specified in http://www.python.org/peps/pep-0263.html.

Indeed, in line 49 there is a French accent in "Académie". I also thought is was ok with UTF-8 but apparently not entirely.

@HuidaeCho
Copy link
Member Author

Indeed, in line 49 there is a French accent in "Académie". I also thought is was ok with UTF-8 but apparently not entirely.

Weird. I think adding from-code to xgettext should be the right fix at this point.

@neteler neteler closed this Oct 15, 2021
@neteler neteler reopened this Oct 15, 2021
@neteler neteler added translation Message translation related bug Something isn't working labels Dec 9, 2021
@neteler neteler added this to the 8.0.1 milestone Dec 9, 2021
@HuidaeCho
Copy link
Member Author

One more message:

# AUTHOR(S): 1994, Stefan Jäger, University of Heidelberg/USGS

xgettext: Non-ASCII comment at or before ../scripts/r.plane/r.plane.py:6.
          Please specify the source encoding through --from-code or through a comment
          as specified in http://www.python.org/peps/pep-0263.html.

@HuidaeCho
Copy link
Member Author

Closed by #2061.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working translation Message translation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants