Skip to content

grass.pygrass: Use unique tmp mapset names GridModule #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 2, 2022
Merged

grass.pygrass: Use unique tmp mapset names GridModule #1967

merged 6 commits into from
Mar 2, 2022

Conversation

wenzeslaus
Copy link
Member

@wenzeslaus wenzeslaus commented Nov 9, 2021 •
edited
Loading

  • Base the temporary mapset name on process ID and node name instead of just module name.
  • Use more robust legalize_vector_name function instead of just removing dots.
  • Allow for underscores in user-provided mapset name prefix (and in processed module name) by using stored prefix to delete temporary mapsets.
  • This by allows multiple GridModules to run on one machine (including HPC) from different processes without the need to specify unique mapset prefix.
  • The previous code required no underscore in the mapset name, but the documentation did not state that. This removes the requirement and avoid possible removal of mapsets with similar name.
  • Documentation now comments on how unique the temporary name is and states when a custom prefix needs to be supplied (multiple GridModules from one process).
  • Adds basic tests for GridModule (developed with the original version).
  • Adds LD_LIBRARY_PATH setting for pytest (and removes broken LD_LIBRARY_PATH setting there).
  • Fixes Pylint check done by pytest so that no actual tests are executed.

@wenzeslaus wenzeslaus added the enhancement New feature or request label Nov 24, 2021
@wenzeslaus wenzeslaus added this to the 8.2.0 milestone Dec 2, 2021
@wenzeslaus wenzeslaus mentioned this pull request Jan 18, 2022
Open
@wenzeslaus wenzeslaus force-pushed the grid-module-better-tmp-mapset-name branch from 70c36fc to 04f2274 Compare January 18, 2022 16:45
@wenzeslaus wenzeslaus marked this pull request as ready for review January 18, 2022 22:12
@wenzeslaus
grass.pygrass: Use unique tmp mapset names GridModule
8d4498f 
- Base the temporary mapset name on process ID and node name instead of just module name.
- Use more robust legalize_vector_name function instead of just removing dots.
- Allow for undescores in user-provided mapset name prefix (and in processed module name) by using stored prefix to delete temporary mapsets.
- This by allows multiple GridModules to run on one machine (including HPC) from different processes without the need to specify unique mapset prefix.
- The previous code required no underscore in the mapset name, but the documentation did not state that. This removes the requirement and avoid possible removal of mapsets with similar name.
- Documentation now comments on how unique the temporary name is and states when a custom prefix needs to be supplied (multiple GridModules from one process).
@wenzeslaus
Add a test (developed with the original version)
f5bbb2c
@wenzeslaus wenzeslaus force-pushed the grid-module-better-tmp-mapset-name branch from 04f2274 to f5bbb2c Compare March 2, 2022 03:57
@wenzeslaus wenzeslaus requested a review from petrasovaa March 2, 2022 04:01
@wenzeslaus wenzeslaus marked this pull request as draft March 2, 2022 05:04
@wenzeslaus wenzeslaus marked this pull request as ready for review March 2, 2022 05:29
@wenzeslaus wenzeslaus merged commit c8106cd into OSGeo:main Mar 2, 2022
@wenzeslaus wenzeslaus deleted the grid-module-better-tmp-mapset-name branch March 2, 2022 15:10
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@wenzeslaus @ninsbl
grass.pygrass: Use unique tmp mapset names in GridModule (OSGeo#1967)
3ef9e95 
- Base the temporary mapset name on process ID and node name instead of just module name.
- Use more robust legalize_vector_name function instead of just removing dots.
- Allow for underscores in user-provided mapset name prefix (and in processed module name) by using stored prefix to delete temporary mapsets.
- This by allows multiple GridModules to run on one machine (including HPC) from different processes without the need to specify unique mapset prefix.
- The previous code required no underscore in the mapset name, but the documentation did not state that. This removes the requirement and avoid possible removal of mapsets with similar name.
- Documentation now comments on how unique the temporary name is and states when a custom prefix needs to be supplied (multiple GridModules from one process).
- Adds basic tests for GridModule (developed with the original version).
- Adds LD_LIBRARY_PATH setting for pytest (and removes broken LD_LIBRARY_PATH setting there).
- Fixes Pylint check done by pytest so that no actual tests are executed.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@wenzeslaus @ninsbl
grass.pygrass: Use unique tmp mapset names in GridModule (OSGeo#1967)
1709ade 
- Base the temporary mapset name on process ID and node name instead of just module name.
- Use more robust legalize_vector_name function instead of just removing dots.
- Allow for underscores in user-provided mapset name prefix (and in processed module name) by using stored prefix to delete temporary mapsets.
- This by allows multiple GridModules to run on one machine (including HPC) from different processes without the need to specify unique mapset prefix.
- The previous code required no underscore in the mapset name, but the documentation did not state that. This removes the requirement and avoid possible removal of mapsets with similar name.
- Documentation now comments on how unique the temporary name is and states when a custom prefix needs to be supplied (multiple GridModules from one process).
- Adds basic tests for GridModule (developed with the original version).
- Adds LD_LIBRARY_PATH setting for pytest (and removes broken LD_LIBRARY_PATH setting there).
- Fixes Pylint check done by pytest so that no actual tests are executed.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@wenzeslaus @neteler
grass.pygrass: Use unique tmp mapset names in GridModule (OSGeo#1967)
b80cbb3 
- Base the temporary mapset name on process ID and node name instead of just module name.
- Use more robust legalize_vector_name function instead of just removing dots.
- Allow for underscores in user-provided mapset name prefix (and in processed module name) by using stored prefix to delete temporary mapsets.
- This by allows multiple GridModules to run on one machine (including HPC) from different processes without the need to specify unique mapset prefix.
- The previous code required no underscore in the mapset name, but the documentation did not state that. This removes the requirement and avoid possible removal of mapsets with similar name.
- Documentation now comments on how unique the temporary name is and states when a custom prefix needs to be supplied (multiple GridModules from one process).
- Adds basic tests for GridModule (developed with the original version).
- Adds LD_LIBRARY_PATH setting for pytest (and removes broken LD_LIBRARY_PATH setting there).
- Fixes Pylint check done by pytest so that no actual tests are executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wenzeslaus @petrasovaa