Skip to content

winGRASS: change form BU Execute to "GenericRead + GenericExecute" #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022
Merged

winGRASS: change form BU Execute to "GenericRead + GenericExecute" #2069

merged 1 commit into from
Jan 5, 2022

Conversation

neteler
Copy link
Member

@neteler neteler commented Jan 5, 2022

forward-port of #2068:

This PR changes Line 761 of of the nsis installer template in the mswindows directory, GRASS-installer.nsi.tmpl from using "BU" "Execute" to using the language - independent ""(s-1-5-32-545)" "GenericRead + GenericExecute" Should fix issue identified in #1965 . Fix based off information at https://peter.bloomfield.online/nsis-access-control-problem-with-built-in-users-group/ , where the BU permissions option does not work on installations of a different language than the language the NSIS installer was created on Windows version 8 and above computers.

Co-authored-by: @dnewcomb

@neteler neteler added the windows Microsoft Windows specific label Jan 5, 2022
@neteler neteler added this to the 8.0.1 milestone Jan 5, 2022
@hellik
Copy link
Member

hellik commented Jan 5, 2022

thanks for forward-porting!

@neteler neteler merged commit 7fca178 into OSGeo:main Jan 5, 2022
@neteler neteler deleted the windows_fix_nsis branch January 5, 2022 22:07
@dnewcomb
Copy link
Contributor

dnewcomb commented Jan 6, 2022 via email

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants