Skip to content

wxGUI: get rid of gradient in map display notebook tabs #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

petrasovaa
Copy link
Contributor

Applies to single window layout only.
Based on https://github.com/wxWidgets/Phoenix/blob/master/wx/lib/agw/aui/tabart.py

@petrasovaa petrasovaa added enhancement New feature or request GUI wxGUI related labels Jan 7, 2022
@petrasovaa petrasovaa added this to the 8.2.0 milestone Jan 7, 2022
@lindakarlovska
Copy link
Contributor

lindakarlovska commented Jan 7, 2022

@petrasovaa I think that it is definitely better without gradient. :-) Only one thing which is probably not much related to this PR - I have tested it with wx version of 4.1.1.

For comparison:
With gradient.:
single_tabart2

Without gradient:
single_tabart

I cannot help myself but I do not like the sharp black notebook page's border. I have not searched for when they did the change but in my previous version 4.0.1, it looked much better.

@petrasovaa
Copy link
Contributor Author

I cannot help myself but I do not like the sharp black notebook page's border. I have not searched for when they did the change but in my previous version 4.0.1, it looked much better.

It doesn't look like that for me. I think the color is probably defined here:

self._border_colour = wx.SystemSettings.GetColour(wx.SYS_COLOUR_BTNSHADOW)

So it would depend on your theme. Maybe we can merge this and tweak it later, I don't really know how this will look like on mac and windows.

@petrasovaa petrasovaa merged commit f57940e into OSGeo:main Jan 10, 2022
@petrasovaa petrasovaa deleted the better-notebook-look branch January 10, 2022 03:34
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants