grass.script: Fix collision of random names in test #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is written in a way that it may fail (with low probability). This is because the function does not make any promisses about that. However, a copy-pasted size of the name left only 2 characters for the random part which increased the collision probability significantly. This change increases the total size the name to increase the size of the random suffix. Failing CI for a recent commit on main seems to be the first occurence of this since the test was introduced in OSGeo#653 14 months ago.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
The test is written in a way that it may fail (with low probability). This is because the function does not make any promises about that. However, a copy-pasted size of the name left only 2 characters for the random part which increased the collision probability significantly. This change increases the total size the name to increase the size of the random suffix. Failing CI for a recent commit on main seems to be the first occurrence of this since the test was introduced in OSGeo#653 14 months ago.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
The test is written in a way that it may fail (with low probability). This is because the function does not make any promises about that. However, a copy-pasted size of the name left only 2 characters for the random part which increased the collision probability significantly. This change increases the total size the name to increase the size of the random suffix. Failing CI for a recent commit on main seems to be the first occurrence of this since the test was introduced in OSGeo#653 14 months ago.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
The test is written in a way that it may fail (with low probability). This is because the function does not make any promises about that. However, a copy-pasted size of the name left only 2 characters for the random part which increased the collision probability significantly. This change increases the total size the name to increase the size of the random suffix. Failing CI for a recent commit on main seems to be the first occurrence of this since the test was introduced in OSGeo#653 14 months ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is written in a way that it may fail (with low probability). This is because the function does not make
any promisses about that.
However, a copy-pasted size of the name left only 2 characters for the random part which increased the collision probability
significantly. This change increases the total size the name to increase the size of the random suffix.
Failing CI for a recent commit on main seems to be the first occurence of this since the test was introduced in #653 14 months ago.