Skip to content

WIP: init: Parse more version of library version with --config #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

wenzeslaus
Copy link
Member

Try to parse more version format and places with --config revision (libgis version).
Print a message when not found or the format was not recognized.
Fails with traceback when format was recognized, but not parsed correctly.

Fixes https://trac.osgeo.org/grass/ticket/4001. Note that since bfdb74d, it does not fail if you ask for something which does not need the files and the files are not there, so assuming the dev files are all or nothing, it gives a proper message if you don't have the development part/package.

Try to parse more version format and places with --congfig revision (libgis version).
Print a message when not found or the format was not recognized.
Fails with traceback when format was recognized, but not parsed correctly.
@wenzeslaus wenzeslaus self-assigned this Feb 1, 2020
@wenzeslaus wenzeslaus changed the title init: Parse more version of library version with --config WIP: init: Parse more version of library version with --config Feb 1, 2020
@metzm
Copy link
Contributor

metzm commented Feb 1, 2020

Note that GIS_H_VERSION is currently not really usable, because it no longer contains the svn revision number of the latest change to gis.h.
I would like to move GIS_H_VERSION to version.h.in and generate it at configure time just like e.g. GRASS_VERSION_STRING. The idea is that GIS_H_VERSION will consist of the GRASS_VERSION_NUMBER and the git hash tag of the latest commit to include.

@ninsbl
Copy link
Member

ninsbl commented Jun 24, 2020

Is here anything left after #405 and #532 have been merged?

@ninsbl
Copy link
Member

ninsbl commented Oct 14, 2021

Can this be closed?

@wenzeslaus wenzeslaus marked this pull request as draft December 2, 2021 02:04
@neteler neteler added enhancement New feature or request Python Related code is in Python labels Dec 9, 2021
@neteler neteler added this to the 8.0.1 milestone Dec 9, 2021
@wenzeslaus
Copy link
Member Author

Closing. A completely different approach is now used to define and get revisions/versions, perhaps even the need for greater robustness is not as big as it was with the old system.

@wenzeslaus wenzeslaus closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants