i.eb.hsebal01: fix manual pixel handling #6004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues mentioned in #6003 that prevent the module from working properly when manual wet/dry pixels are specified:
d_t0dem
,d_z0m
, andd_eact
arrays were never populated before iteration loops. This caused all pixel values to remain zero, leading to invalidd_rah_dry
andd_roh_dry
,NaN
results, and premature failure withDelta T Convergence failed
.-c
flag, the provided wet/dry pixel coordinates must be interpreted as row/col indices. These were not assigned properly torowWet
,colWet
,rowDry
,colDry
, leading to uninitialized or stale values.-c
was specified, causing confusion.flag3->answer
is true:The changes in the module have been verified to run successfully in all modes:
-a
)-c
)-c
)The results matched the expected output rasters in each mode.
A test suite for the module will be added once these changes are merged.
Closes #6003