r.kappa: Fix unchecked return value from library in stats.c #6011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
ShubhamDesai
changed the title
marisn
requested changes
Jul 2, 2025
marisn
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue identified by Coverity Scan ( CID : 1207210)
The warning was caused by an unchecked return value from the remove() function, which may fail and return a non-zero error code. In this fix, the return value of remove() is explicitly checked, and a warning is logged if the file removal fails. This follows a more defensive programming approach.
An alternative fix would have been to suppress the warning using a (void) cast, since the program exits immediately afterward via G_fatal_error().