-
-
Notifications
You must be signed in to change notification settings - Fork 362
v.class: Added test cases #6071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please test the specific break values, not just the number of classes?
I added the breakpoint values for a few tests. Is that what you meant? For a few tests it is not possible to know the values beforehand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are slow. There are couple options to optimize this. If I understand this correctly the fixture runs for each test, consider running it just once if appropriate. Also running db.execute in loop is expensive, see the manual page of db.execute to avoid that.
I have used a single db.execute query instead of inside a loop. I am also using a module scope for shared state. Please let me know if this works. |
It's still the longest pytest (see the windows CI):
Perhaps mark the large data test as skipped and see if it helps. |
I have reduced the number of points to 100 instead of 1000. I think that should reduce the processing time significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good now, thanks!
No description provided.