Skip to content

r3.info: Add test file#6098

Merged
petrasovaa merged 2 commits intoOSGeo:mainfrom
NishantBansal2003:test/r3-info
Jul 22, 2025
Merged

r3.info: Add test file#6098
petrasovaa merged 2 commits intoOSGeo:mainfrom
NishantBansal2003:test/r3-info

Conversation

@NishantBansal2003
Copy link
Contributor

ref: #5995

This PR introduces a regression test suite for the r3.info module, ensuring that future changes—particularly the upcoming addition of JSON support—do not break existing behavior.

It also fixes a bug in flag handling: previously, combining -r and -h (-rh) produced range output in shell format but history output in plain format. Now, whenever the -h flag is used alongside -g or -r, the shell format will be applied otherwise, the plain format is used.

Signed-off-by: Nishant Bansal <[email protected]>
@github-actions github-actions bot added Python Related code is in Python C Related code is in C module tests Related to Test Suite raster3d labels Jul 22, 2025
@petrasovaa
Copy link
Contributor

I think the fix makes sense, good catch. Since you are already changing it, please also change "Location:" (in plain mode) to "Project:" for consistency. This somehow got lost during the location to project rename a while ago.

Signed-off-by: Nishant Bansal <[email protected]>
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petrasovaa petrasovaa enabled auto-merge (squash) July 22, 2025 21:13
@petrasovaa petrasovaa merged commit 63bc94a into OSGeo:main Jul 22, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in GRASS JSON Outputs Jul 22, 2025
@github-actions github-actions bot added this to the 8.5.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C module Python Related code is in Python raster3d tests Related to Test Suite

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants