lib/imagery: Fix Resource Leak Issue in iscatt_core.c #6102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nilason
requested changes
Jul 24, 2025
| @@ -102,6 +102,7 @@ int I_create_cat_rast(struct Cell_head *cat_rast_region, const char *cat_rast) | |||
| } | |||
|
|
|||
| fclose(f_cat_rast); | |||
| G_free(row_data); | |||
There was a problem hiding this comment.
row_data needs to be freed before return on L100 too.
| @@ -712,9 +717,12 @@ int I_compute_scatts(struct Cell_head *region, struct scCats *scatt_conds, | |||
| for (i_band = 0; i_band < n_bands; i_band++) | |||
| bands_ids[i_band] = -1; | |||
|
|
|||
| if (n_bands != scatts->n_bands || n_bands != scatt_conds->n_bands) | |||
| if (n_bands != scatts->n_bands || n_bands != scatt_conds->n_bands) { | |||
There was a problem hiding this comment.
This if statement can be moved to the top of the function, before any mallocs. Then there will be no need for unnecessary mallocs and frees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue identified by Coverity Scan ( CID : 1208098, 1208099, 1208100, 1543965, 1543972, 1543985, 1543987, 1543988, 1543989)