v.category: Use CSV format instead of shell format #6132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Bansal <[email protected]>
Signed-off-by: Nishant Bansal <[email protected]>
github-actions
bot
added
vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6025
Since the print style is not key-value format when using the shell output, I changed the format from shell to CSV for the
report,print, andlayersoptions.Also, the changes in the last commit were not originally mentioned in the issue, but I felt that the CSV output should include headers. So, I added headers for the above-mentioned options in a backward-compatible way i.e., if the
-gflag is given without specifying the CSV format, headers will be skipped.I also read some discussions where we want CSV output to be more aligned with JSON. So, for the
printoption, I updated the CSV format to better match the structure of the JSON output.Additionally, for both the
printandreportoptions, I added aseparatoroption that can be used with CSV.Let me know if any (or all) of the changes in the last commit are useful. If not, I’ll revert them.