r.out.gdal: Skip nodata and range checks if export is forced #6170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I see that r.out.gdal lacks a test. Will add one. [Done.] |
ninsbl
commented
Aug 6, 2025
| createopt="COMPRESS=LZW", | ||
| ) | ||
| assert output_file.exists(), f"{mapname} not exportd to {output_file}" | ||
| # Here I would like to assert "Checking GDAL data type and nodata value" not in std_err |
There was a problem hiding this comment.
I cannot figure out how to capture the std_err with Tools... Setting the capture_stderr parameter in Tools to True does not seem to be enough... Any hints are moste welcome...
ninsbl
commented
Aug 6, 2025
|
|
||
|
|
||
| @pytest.mark.parametrize("file_format", list(FORMAT_DICT.keys())) | ||
| def test_basic_cog_export(simple_raster_map, file_format): |
There was a problem hiding this comment.
This test fails for COG, although the export is successful as r.out.gdal gives returncode -11. I assume the warning about the MEM driver is the reason? How can I circumvent that false negative testresult?
github-actions
bot
added
Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up a post on Discourse:
https://discourse.osgeo.org/t/r-out-gdal-performance-with-known-data-type-and-range/148619
The code changes make r.out.gdal skip data range and nodata checks if the f-flag (force export) as well as the nodata, and data type option are given by the user. In that case the assumption is the user has made a deliberate choice about this parameters. Skipping checks alomst cuts export time by half...
In a worflow I have to regularly export data to multi-band GeoTiff (COG actually) where I know the data range and the suitable GDAL data type across all bands to export in advance. Even though I use the -f flag and set the nodata option, a full data type and nodata check is performed on every band. To me that feels like unnecessary processing and seems inconsistent with the documentation of the -f flag.
Any feedback is welcome...