Skip to content

Conversation

@schaefi
Copy link
Collaborator

@schaefi schaefi commented Nov 3, 2024

tox was used as sort of a make target to run unit
tests and more in a venv. However, since we switched everything to poetry it's no longer needed to let tox create the python virtual environments. This commit moves the tox targets into the Makefile and adapts the github workflow files accordingly

@schaefi schaefi self-assigned this Nov 3, 2024
@schaefi schaefi force-pushed the remove_tox branch 3 times, most recently from ce34c08 to 92c325b Compare November 3, 2024 17:20
@schaefi schaefi marked this pull request as ready for review November 3, 2024 17:25
@schaefi schaefi requested a review from Conan-Kudo November 3, 2024 17:25
@Conan-Kudo
Copy link
Member

Why'd we drop the CentOS tests? And what happened to the Fedora tests?

@schaefi
Copy link
Collaborator Author

schaefi commented Nov 3, 2024

Why'd we drop the CentOS tests? And what happened to the Fedora tests?

I reduced the scope of the custom script tests for the following reasons:

  • running them in docker is unstable because every now and then the tagging fails, running the same tests in one container engine is more than enough, podman it is
  • The script code runs for test_suseSetupProduct.py are suse specific and it doesn't make sense to run them in non suse containers
  • The test_baseVagrantSetup.py tests the vagrant setup functions which are using core tools like cp, useradd, and so on are expected to work in the same way on any linux distribution. It doesn't make sense to run this shell code more than once.
  • I dropped all targets except for TW and Leap because of the suse specific product name tests. There are no fedora or any other linux specific tests in this test/scripts/ implementation
  • We want to get rid of the custom script lib in kiwi anyway
  • The tests here were switched off for a long time because of the container runtime to be so unstable (timeouts on fetching them) leading to false positive test results. The current reduced matrix should not have this problem. If it comes back I will switch all this off

@Conan-Kudo
Copy link
Member

I dropped all targets except for TW and Leap because of the suse specific product name tests. There are no fedora or any other linux specific tests in this test/scripts/ implementation

Can we add at least one Fedora or CentOS one to make sure the non-product stuff works?

@schaefi
Copy link
Collaborator Author

schaefi commented Nov 4, 2024

Can we add at least one Fedora or CentOS one to make sure the non-product stuff works?

@Conan-Kudo sure, can you tell me a stable registry URL to fetch a Fedora container from ? I'll add that then

@Conan-Kudo
Copy link
Member

registry.fedoraproject.org/fedora:latest

tox was used as sort of a make target to run unit tests
and more in a python virtualenv. However, since we switched
everything to poetry it's no longer needed to let tox create
the python virtual environments. This commit moves the tox
targets into the Makefile and adapts the github workflow
files accordingly. In addition the scripts container based
tests were re-activated and fixed such that they succeed
again.
The SUSE documentation is produced through a conversion
of the ReST source into docbook. The name kiwi is reserved
in the index and needs to be referenced as kiwi-ng when
used as command.
@Conan-Kudo Conan-Kudo enabled auto-merge November 6, 2024 08:07
@schaefi schaefi disabled auto-merge November 6, 2024 08:26
@schaefi schaefi merged commit 463f044 into main Nov 6, 2024
14 checks passed
@schaefi schaefi deleted the remove_tox branch November 6, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants