-
Notifications
You must be signed in to change notification settings - Fork 171
Remove tox dependency #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tox dependency #2673
Conversation
ce34c08 to
92c325b
Compare
|
Why'd we drop the CentOS tests? And what happened to the Fedora tests? |
I reduced the scope of the custom script tests for the following reasons:
|
Can we add at least one Fedora or CentOS one to make sure the non-product stuff works? |
@Conan-Kudo sure, can you tell me a stable registry URL to fetch a Fedora container from ? I'll add that then |
|
|
tox was used as sort of a make target to run unit tests and more in a python virtualenv. However, since we switched everything to poetry it's no longer needed to let tox create the python virtual environments. This commit moves the tox targets into the Makefile and adapts the github workflow files accordingly. In addition the scripts container based tests were re-activated and fixed such that they succeed again.
The SUSE documentation is produced through a conversion of the ReST source into docbook. The name kiwi is reserved in the index and needs to be referenced as kiwi-ng when used as command.
tox was used as sort of a make target to run unit
tests and more in a venv. However, since we switched everything to poetry it's no longer needed to let tox create the python virtual environments. This commit moves the tox targets into the Makefile and adapts the github workflow files accordingly