Poetry build sdist timestamps set to epoch 0 #2732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of poetry set the timestamp for all source files to epoch 0. Such sources are not accepted by e.g Debian FTP servers and in general I don't like when tools changes their behavior just like that. This commit forces an older version of poetry for the purpose of creating the sdist tarball which then gets published on pypi. The argumentation for reproducible builds by forcing source files to a certain timestamp doesn't fly for me. I'm open for any better solution though. This Fixes #2730
Conan-Kudo
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of poetry set the timestamp for all source files to epoch 0. Such sources are not accepted by e.g Debian FTP servers and in general I don't like when tools changes their behavior just like that. This commit forces an older version of poetry for the purpose of creating the sdist tarball which then gets published on pypi. The argumentation for reproducible builds by forcing source files to a certain timestamp doesn't fly for me. I'm open for any better solution though. This Fixes #2730