Skip to content

Conversation

@uecasm
Copy link
Contributor

@uecasm uecasm commented Jul 6, 2025

Fixes part of this issue

Changes proposed in this pull request:

  • Fixes regression in get_partition_node_name for targets that do not support the START column in lsblk.

@schaefi
Copy link
Collaborator

schaefi commented Jul 7, 2025

@uecasm Uhh, good catch thanks.

Can you give me a short background explanation for which devices we hit the regression ? The places in code where we call it targets the storage disk which is expected to hold a partition table and thus proper start addresses. Thanks

@schaefi schaefi self-requested a review July 7, 2025 07:00
@schaefi
Copy link
Collaborator

schaefi commented Jul 7, 2025

Ah forget my last question, you referenced an issue link.. just reading

@schaefi
Copy link
Collaborator

schaefi commented Jul 7, 2025

A reproducer to the issue would be great. I believe if you can send

sfdisk -d /dev/nvme0n1 > table

From an affected system, I should be able to reproduce this also on a loop device

Thoughts ?

@uecasm
Copy link
Contributor Author

uecasm commented Jul 8, 2025

This isn't device-specific, it's an issue with the version of lsblk. As noted, I'm testing on a Leap 15.5 target and the version in there does not support this column. The START column was not added until util-linux-systemd 2.38, and 15.5 has 2.37.4.

@schaefi
Copy link
Collaborator

schaefi commented Jul 8, 2025

This isn't device-specific, it's an issue with the version of lsblk. As noted, I'm testing on a Leap 15.5 target and the version in there does not support this column. The START column was not added until util-linux-systemd 2.38, and 15.5 has 2.37.4.

I see, thanks and the comment makes that part clear 👍

@schaefi schaefi self-requested a review July 8, 2025 07:13
@schaefi schaefi merged commit ca746a3 into OSInside:main Jul 8, 2025
14 checks passed
@uecasm uecasm deleted the patch-1 branch July 8, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants