Fixed check for unallocated space on disk #2851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the check for unallocated space was only working for GPT and there it was also not really stable. The check was based on verifying if the backup GPT table is really at the end of the disk. Depending on which tool was used to dump the image on the target this "mistake" often got corrected by the tools that dumped the image. In this case the check no longer worked. This commit improves the check by another test which looks for the real free bytes on disk compared to the current partition geometry.
schaefi
force-pushed
the
fix_disk_has_unallocated_space_check
branch
from
8157098 to
b40829d
Compare
Conan-Kudo
approved these changes
Jul 9, 2025
uecasm
reviewed
Jul 17, 2025
| # to detect a geometry change for non GPT based disks. | ||
| # Thus we assume it's not fully allocated and allow | ||
| # for resize | ||
| if sfdisk --list-free "${disk_device}" 2>&1 | grep -q "${flag}"; then |
There was a problem hiding this comment.
Reposting here in case you didn't see my comment in the forum. I don't think this will behave as you expect, since this warning does not disappear after successful resize by kiwi-repart.
There was a problem hiding this comment.
@uecasm I also think I did not well thought through all cases. In my test that resizes to the full capacity, sfdisk did no longer show any warning and just displayed
Unpartitioned space /dev/sda: 0 B, 0 bytes, 0 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
But I found other issues and more changes will be needed
schaefi
added a commit
that referenced
this pull request
Jul 17, 2025
The partition id metadata file is used in the kiwi-repart module. If a user wants to use the kiwi repart module permanently, this metadata file needs to stay in the system. Therefore it should not be automatically deleted by the cleanup. A disk.sh hook script can be used to force the deletion of the file though. This is related #2851
schaefi
added a commit
that referenced
this pull request
Jul 17, 2025
Using sfdisk for relocation and verification makes this part more consistent. We also want to move away from gdisk. This is related to #2851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the check for unallocated space was only working for GPT and there it was also not really stable. The check was based on verifying if the backup GPT table is really at the end of the disk. Depending on which tool was used to dump the image on the target this "mistake" often got corrected by the tools that dumped the image. In this case the check no longer worked. This commit improves the check by another test which looks for the real free bytes on disk compared to the current partition geometry.