Skip to content

Conversation

@andreabolognani
Copy link
Contributor

A recent commit changed the way these are looked up and accidentally broke image building on riscv64, with

KiwiBootLoaderGrubSecureBootError: Signed grub2 efi loader not found

now being raised for kiwi recipes that worked just fine before that moment.

Fixes: 1975723

Note: this currently breaks the test suite, and I couldn't figure out how to make that issue go away. Guidance on the matter would be very welcome.

@andreabolognani
Copy link
Contributor Author

Fixed a spot where I had failed to add the riscv64 pattern. Thanks, David!

Still getting the following failures which I'm not sure what to do about:

=== short test summary info ===
FAILED bootloader/config/grub2_test.py::TestBootLoaderConfigGrub2::test_setup_disk_boot_images_bios_plus_efi_secure_boot_no_shim_install - IndexError: pop from empty list
FAILED bootloader/config/grub2_test.py::TestBootLoaderConfigGrub2::test_setup_disk_boot_images_bios_plus_efi_secure_boot_no_shim_at_all - IndexError: pop from empty list
FAILED bootloader/config/grub2_test.py::TestBootLoaderConfigGrub2::test_setup_install_boot_images_efi_secure_boot - IndexError: pop from empty list
=== 3 failed, 1788 passed in 76.93s (0:01:16) ===

@schaefi
Copy link
Collaborator

schaefi commented Jul 14, 2025

Thanks great catch and sorry I overlooked to update this architecture correctly.

The tests are a beast. If you are ok I'll fix the unit tests to pass with your code change ?

@andreabolognani
Copy link
Contributor Author

@schaefi by all means go ahead :)

@schaefi
Copy link
Collaborator

schaefi commented Jul 15, 2025

@schaefi by all means go ahead :)

@andreabolognani done :) Let's wait for the tests to pass. Once done, can you squash the commits into one as you see fit and then we can merge.

Thanks much

A recent commit changed the way these are looked up and
accidentally broke image building on riscv64, with

  KiwiBootLoaderGrubSecureBootError: Signed grub2 efi loader not found

now being raised for kiwi recipes that worked just fine
before that moment.

Fixes: 1975723
Thanks: David Abdurachmanov <[email protected]>
Thanks: Marcus Schäfer <[email protected]>
Signed-off-by: Andrea Bolognani <[email protected]>
@andreabolognani
Copy link
Contributor Author

@schaefi excellent, thank you!

@schaefi schaefi merged commit 75f2138 into OSInside:main Jul 15, 2025
14 checks passed
@andreabolognani andreabolognani deleted the riscv64 branch July 15, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants