Fix subtree reuse #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a subtree was used multiple times in a behavior tree, the generator produced incorrect sibling/child indices because it reused the same XML element IDs for all instances. This caused getIndexedNode() to always return the first instance's entry. The fix expands subtrees by creating deep copies of their content before processing, ensuring each instance has unique element IDs. Fixes: #28 Signed-off-by: Gerson Fernando Budke <[email protected]>
Add a sample that validates correct behavior tree traversal when a subtree is used multiple times. This reproduces the scenario from issue #28 where incorrect indices caused nodes to be skipped during execution. The behavior tree structure tests: Sequence -> SubTree(sub) -> A -> SubTree(sub) -> B Expected execution order: sub -> A -> sub -> B The test verifies that all nodes are evaluated in the correct order and that no nodes are skipped due to incorrect sibling indices. Signed-off-by: Gerson Fernando Budke <[email protected]>
otavio
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix the issue with the usage of subtrees.