Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode Implimentation for Desktop #1169

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Shubham-Patel07
Copy link

@Shubham-Patel07 Shubham-Patel07 commented Jan 19, 2025

What kind of changes does this PR include?

  • Fixes or refactors
  • A new Enhancement
  • Additional documentation
  • Something else

Description

I have Implemented the dark mode for desktop

Relations

Closes #404

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@Shubham-Patel07
Copy link
Author

Hi @jgadsden sir,
I have used NativeTheme for the implemented as described in the issue, and please can you help me with the styling such that there is minimal repetition of code.

@jgadsden
Copy link
Collaborator

Hello @Shubham-Patel07 , thanks for the start on this feature, marking this draft because it is a work in progress
Screenshot 2025-01-24 at 07 14 07

@jgadsden jgadsden marked this pull request as draft January 24, 2025 07:15
@jgadsden jgadsden self-requested a review January 25, 2025 10:18
@jgadsden jgadsden added the enhancement New feature or request label Jan 25, 2025
@jgadsden
Copy link
Collaborator

I agree @Shubham-Patel07 there are still many views that need dark-mode applied
there must be an easy way to do this via scss?

@Shubham-Patel07
Copy link
Author

Hi @jgadsden sir,
Yess i found out a way now we only need to make change in global scss file i.e dark-mode.scss

@Shubham-Patel07 Shubham-Patel07 marked this pull request as ready for review January 28, 2025 19:20
@Shubham-Patel07 Shubham-Patel07 marked this pull request as draft January 28, 2025 19:21
@Shubham-Patel07 Shubham-Patel07 marked this pull request as ready for review January 29, 2025 04:32
@Shubham-Patel07
Copy link
Author

Hi @jgadsden sir,
Please review the code and let me know weather to write UI tests in Cypress or Jest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide dark mode for desktop
2 participants