fix: make payload:null handling in connection_init consistent between…

… protocols
Object905 · Dec 28, 2024 · 09effc9 · 09effc9
1 parent e78f8c6
commit 09effc9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/strawberry/subscriptions/protocols/graphql_transport_ws/handlers.py b/strawberry/subscriptions/protocols/graphql_transport_ws/handlers.py
@@ -167,7 +167,8 @@ async def handle_connection_init(self, message: ConnectionInitMessage) -> None:
             self.connection_init_timeout_task.cancel()
 
         payload = message.get("payload", {})
-
+        if payload is None:
+            payload = {}
         if not isinstance(payload, dict):
             await self.websocket.close(
                 code=4400, reason="Invalid connection init payload"

diff --git a/strawberry/subscriptions/protocols/graphql_ws/handlers.py b/strawberry/subscriptions/protocols/graphql_ws/handlers.py
@@ -97,7 +97,9 @@ async def handle_message(
 
     async def handle_connection_init(self, message: ConnectionInitMessage) -> None:
         payload = message.get("payload")
-        if payload is not None and not isinstance(payload, dict):
+        if payload is None:
+            payload = {}
+        if not isinstance(payload, dict):
             await self.send_message({"type": "connection_error"})
             await self.websocket.close(code=1000, reason="")
             return