New and updated reprs for Variable, ParticleFile, Field, VectorField, and ParticleSet
#1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
changed the title
reprs for reprs for Variable, ParticleFile, Field, and ParticleSet
VeckoTheGecko
force-pushed
the
better-prints
branch
from
234bacf
to
fd7db3a
Compare
docs/examples/parcels_tutorial.ipynb
Outdated
There was a problem hiding this comment.
The _warn_outputdt_release_desync() call should be fixed by #1744
But it would be nice if the particles are listed one per line in the other cells?
Multiline particle printing Update function naming FieldSet repr
VeckoTheGecko
force-pushed
the
better-prints
branch
from
5283cc6
to
7db3d62
Compare
| return textwrap.dedent(out).strip() | ||
|
|
||
|
|
||
| def fieldset_repr(fieldset: FieldSet) -> str: |
There was a problem hiding this comment.
The fields now don't print their own name; that would be the most important information?
| return f"[\n{items_str}\n{indentation_str_end}]" | ||
|
|
||
|
|
||
| def particleset_repr(pset: ParticleSet) -> str: |
There was a problem hiding this comment.
print(pset) now also prints all the fields, that would be a bit redundant?
And the list of particles is a generator object?
`default_repr` doesn't play well with None types
VeckoTheGecko
changed the title
reprs for Variable, ParticleFile, Field, and ParticleSetreprs for Variable, ParticleFile, Field, VectorField, and ParticleSet
erikvansebille
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New/updated reprs for:
contributes to #1693