[ROS2] Fix deprecated PCL API: setFilterLimitsNegative -> setNegative #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxmerkt
changed the title
Member
Author
|
@wep21 Can you please check that these changes do not impact performance / functionality? |
wep21
reviewed
Apr 14, 2024
|
|
||
| // transform pointcloud from sensor frame to fixed robot frame | ||
| pcl::transformPointCloud(pc, pc, sensor_to_base); | ||
| pcl_ros::transformPointCloud(pc, pc, sensor_to_base_transform_stamped); |
Contributor
There was a problem hiding this comment.
@wxmerkt Do you have any reason to migrate transform method from pcl to pcl_ros?
Member
Author
There was a problem hiding this comment.
It's no longer available in the new Rolling version
Contributor
|
It seems to work fine. |
Member
Author
|
Thank you @wep21 |
Contributor
|
@wxmerkt Could you create a new release for ros2? |
Member
Author
|
@wep21: Done - thank you for the ping :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf.
PointCloudLibrary/pcl@1036334