Fix issue #14986 Tool to add blocks to db #15054
Open
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prestonvanloon
requested changes
Apr 1, 2025
| @@ -1150,3 +1151,59 @@ func (s *Store) deleteValidatorHashes(tx *bolt.Tx, root []byte) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (s *Store) AddBeaconBlock(ctx context.Context, serBlock []byte) error { | |||
| @@ -1150,3 +1151,59 @@ func (s *Store) deleteValidatorHashes(tx *bolt.Tx, root []byte) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (s *Store) AddBeaconBlock(ctx context.Context, serBlock []byte) error { | |||
There was a problem hiding this comment.
Please add a godoc comment
Comment on lines
+1191
to
+1194
| parentBlk, err := unmarshalBlock(ctx, parentExists) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Do you need to unmarshal the whole block to get the slot or can we read only that data from the ssz format? cc: @kasey
Comment on lines
+1202
to
+1205
| // Save the block | ||
| if err := bkt.Put(blockRoot[:], serBlock); err != nil { | ||
| return errors.Wrapf(err, "could not write block to db with root %#x", blockRoot) | ||
| } |
There was a problem hiding this comment.
What about all of the indices we have on blocks?
Why can't you use SaveBlock?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Tool to add blocks to db
Which issues(s) does this PR fix?
#14986
Fixes #
Other notes for review
Acknowledgements