Execution API: Support blobs_bundle_v2 for PeerDAS
#15167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
reviewed
Apr 15, 2025
| func (vs *Server) constructGenericBeaconBlock(sBlk interfaces.SignedBeaconBlock, blobsBundle *enginev1.BlobsBundle, winningBid primitives.Wei) (*ethpb.GenericBeaconBlock, error) { | ||
| func (vs *Server) constructGenericBeaconBlock( | ||
| sBlk interfaces.SignedBeaconBlock, | ||
| blobsBundle enginev1.BlobsBundler, |
There was a problem hiding this comment.
blobsBundle ==> blobsBundler?
(To ensure consistency between variable name and type.)
| @@ -12,7 +12,7 @@ import ( | |||
| // GetPayloadResponseV(1|2|3|4) value. | |||
| type GetPayloadResponse struct { | |||
| ExecutionData interfaces.ExecutionData | |||
| BlobsBundle *pb.BlobsBundle | |||
| BlobsBundle pb.BlobsBundler | |||
There was a problem hiding this comment.
BlobsBundle ==> BlobsBundler?
(To ensure struct field consistency with type.)
proto/engine/v1/electra.proto
Outdated
| @@ -81,3 +81,11 @@ message ExecutionBundleElectra { | |||
| bool should_override_builder = 4; | |||
| repeated bytes execution_requests = 5; | |||
| } | |||
|
|
|||
| message ExecutionBundleFulu { | |||
There was a problem hiding this comment.
Is it possible to create a new fulu.proto file to avoid having Fulu structs defined in the electra.proto file?
nalepae
approved these changes
Apr 16, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
blobs_bundle_v2as defined in execution-apis#630, enabling compatibility with the latest Fulu-era blob response format.Summary of Changes
BlobsBundlerinterface to abstract over both v1 and v2 blob bundle implementationsconstructGenericBeaconBlocklogic to support type assertions for bothBlobsBundleandBlobsBundleV2based on the block versionGetBlobs()andGetProofs()from theBlobsBundlerinterfaceBlobsBundleV2andExecutionBundleFulu