[Outlook] (sensitivity label) Add the unified manifest to the sample #995
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the unified manifest for Microsoft 365 to the Outlook sensitivity label sample, moves event handler logic into a dedicated runtime file, and updates build/configuration and documentation to reflect those changes.
- Introduce a unified manifest (
manifest.json,m365agents.yml) and updatemanifest.xml/manifest-localhost.xmlto referencelaunchevent.html/launchevent.jsand include the attachments event. - Move all event handler logic from
commands.jsintolaunchevent.jsand remove the legacycommands.jsfile. - Update build pipeline (
webpack.config.js) and sample documentation (README.md) with unified manifest instructions and adjust styling in taskpane.
Reviewed Changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Samples/outlook-verify-sensitivity-label/webpack.config.js | Fix development HTTPS setup and ensure unified manifest files are copied and transformed correctly |
| Samples/outlook-verify-sensitivity-label/src/taskpane/taskpane.html | Added inline background color style |
| Samples/outlook-verify-sensitivity-label/src/launchevent/launchevent.js | Centralized event handlers and fixed label-ID lookup when child labels exist |
| Samples/outlook-verify-sensitivity-label/src/launchevent/launchevent.html | Updated script include to load launchevent.js |
| Samples/outlook-verify-sensitivity-label/src/commands/commands.js | Removed legacy commands file |
| Samples/outlook-verify-sensitivity-label/package.json | Updated package metadata, scripts, and dependencies |
| Samples/outlook-verify-sensitivity-label/manifest.xml | Switched to launchevent pages, added attachments event |
| Samples/outlook-verify-sensitivity-label/manifest.json | Added new unified manifest for Microsoft 365 with autoscale events |
| Samples/outlook-verify-sensitivity-label/manifest-localhost.xml | Updated local manifest to reference launchevent and include attachments event |
| Samples/outlook-verify-sensitivity-label/m365agents.yml | Added Microsoft 365 Agents Toolkit provisioning/deployment config |
| Samples/outlook-verify-sensitivity-label/README.md | Expanded instructions for unified manifest and updated run scenarios |
| Samples/outlook-verify-sensitivity-label/.gitignore | Added ignore patterns for build, env, and artifacts |
Comments suppressed due to low confidence (2)
Samples/outlook-verify-sensitivity-label/src/launchevent/launchevent.js:456
- The @returns JSDoc type is incorrect: getLabel returns a label object, not a number. Update the type to reflect the actual return value.
* @returns {number} The sensitivity label requested.
Samples/outlook-verify-sensitivity-label/src/taskpane/taskpane.html:24
- [nitpick] Inline styling reduces maintainability; move the background-color definition into taskpane.css instead of using a style attribute.
<body class="ms-font-m ms-welcome ms-Fabric" style="background-color: white;">
| }, | ||
| server: { | ||
| type: "https", | ||
| options: env.WEBPACK_BUILD || options.https !== undefined ? options.https : await getHttpsOptions(), |
There was a problem hiding this comment.
Operator precedence causes the ternary expression to be evaluated on the result of the logical OR. Consider adding parentheses around the ternary or splitting the condition to ensure the intended HTTPS options are selected.
| options: env.WEBPACK_BUILD || options.https !== undefined ? options.https : await getHttpsOptions(), | |
| options: env.WEBPACK_BUILD || (options.https !== undefined ? options.https : await getHttpsOptions()), |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Consider having subfolders for json vs add-in only. The root folder can default to .json content. package.json should have separate instructions for xml vs json manifest. Consider including package-lock so customers will have a last known good package state.
Ricky may have some more comments about how it's organized.
Also, I'm not seeing any change to assets/sample.json (e.g., change updateDateTime, products)
Thanks for the feedback, @ElizabethSamuel-MSFT. I'll look into creating subfolders for the manifests. @Rick-Kirkham Please hold off on reviewing this PR for now until I reorganize the sample structure. |
What's in this Pull Request?