Skip to content

fix(SDK): getPagedMembers meeting error #14304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2025
Merged

fix(SDK): getPagedMembers meeting error #14304

merged 6 commits into from
Jul 22, 2025

Conversation

nliu-ms
Copy link
Contributor

@nliu-ms nliu-ms commented Jul 21, 2025

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/33869512

Fix issue: #14274

  1. context.activity.channelData is undefined instead of {}
  2. connectorClient is not set in context

bump Agents SDK to 0.6.1, @microsoft/agents-hosting-teams renamed to @microsoft/agents-hosting-extensions-teams

@nliu-ms nliu-ms changed the title fix: getPagedMembers meeting error fix(SDK): getPagedMembers meeting error Jul 21, 2025
@nliu-ms nliu-ms force-pushed the nliu/channelData branch from f2bed36 to 2374018 Compare July 22, 2025 01:56
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (f3c2a72) to head (04f8678).
Report is 5 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #14304      +/-   ##
==========================================
- Coverage   90.00%   89.99%   -0.02%     
==========================================
  Files         647      647              
  Lines       38791    38800       +9     
  Branches     7835     7840       +5     
==========================================
+ Hits        34915    34918       +3     
- Misses       1759     1766       +7     
+ Partials     2117     2116       -1     
Files with missing lines Coverage Δ
packages/sdk/src/bot/teamsBotSsoPrompt.ts 86.99% <100.00%> (+0.10%) ⬆️
packages/sdk/src/conversation/interface.ts 100.00% <100.00%> (ø)
.../sdk/src/conversation/sso/botSsoExecutionDialog.ts 61.18% <100.00%> (ø)
...ation/sso/defaultBotSsoExecutionActivityHandler.ts 71.87% <100.00%> (ø)
...k/src/conversationWithCloudAdapter/notification.ts 92.65% <100.00%> (+0.18%) ⬆️
...ackages/sdk/src/messageExtension/executeWithSSO.ts 94.00% <ø> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nliu-ms nliu-ms merged commit acf227d into dev Jul 22, 2025
19 of 20 checks passed
@nliu-ms nliu-ms deleted the nliu/channelData branch July 22, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants