add_warning_in_flow_save #10338
Open
add_warning_in_flow_save #10338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally. |
|
Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally. |
ShawnXuan
reviewed
Sep 28, 2023
| @@ -703,6 +703,12 @@ def save( | |||
| """ | |||
| if isinstance(path_or_buffer, str): | |||
| path_or_buffer = Path(path_or_buffer) | |||
| if os.path.isdir(path_or_buffer) and not save_as_external_data: | |||
| path_or_buffer = path_or_buffer / "model.pt" | |||
ShawnXuan
reviewed
Sep 28, 2023
| warnings.warn( | ||
| f"The save path cannot be a dir name from oneflow-0.9.1! The system | ||
| will automatically complete it into the file name as {path_or_buffer}" | ||
| ) |
There was a problem hiding this comment.
warnings.warn(
f"The save path cannot be a dir name from oneflow-0.9.1! The system "
f"will automatically complete it into the file name as {path_or_buffer}"
)
ShawnXuan
approved these changes
Oct 7, 2023
|
CI failed when running job: cuda-module. PR label automerge has been removed |
Speed stats: |
Open
|
View latest API docs preview at: https://oneflow-staging.oss-cn-beijing.aliyuncs.com/docs/Oneflow-Inc/oneflow/pr/10338/ |
|
CI failed when running job: cuda-module. PR label automerge has been removed |
Speed stats: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.