Skip to content

modify clip grad #10441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hanwen-sun wants to merge 2 commits into from
Closed

modify clip grad #10441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b64d42
modify clip grad
hanwen-sun Mar 6, 2024
4087737
auto format by CI
oneflow-ci-bot Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions python/oneflow/nn/utils/clip_grad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ def clip_grad_norm_(
]
total_norm = norms[0] if len(norms) == 1 else flow.min(flow.stack(norms))
else:
"""
# data parallel
total_norm = flow.linalg.vector_norm(
flow.stack(
[
Expand All @@ -130,6 +132,22 @@ def clip_grad_norm_(
),
norm_type,
)
"""
# tensor parallel:
partial_grad_squre_sum = flow.sum(
flow.stack(
[
flow.sum(flow.pow(p.grad.detach(), norm_type)).to_local()
for p in parameters
]
)
)

flow.comm.all_reduce(partial_grad_squre_sum)
total_norm = flow.pow(partial_grad_squre_sum, 1 / norm_type)
total_norm = total_norm.to_global(
sbp=sbp_broadcast, placement=param0_placement
)
if error_if_nonfinite and flow.logical_or(
total_norm.isnan(), total_norm.isinf()
):
Expand Down