New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix layernorm grad sbp #10561

Merged

ShawnXuan merged 1 commit into layer_norm_grad_npu from fix_ln_grad_sbp

Nov 11, 2024

Contributor

ShawnXuan commented Nov 10, 2024

Fix SBP settings for LayerNormGradOp to ensure correct gradient aggregation for gamma_diff and beta_diff

Changes

Updated SBP strategy in LayerNormGradOp: Set gamma_diff and beta_diff to use PartialSum instead of Split to avoid dimension mismatches during distributed training.
Added consistency check for begin_norm_axis and begin_params_axis: Enforce equality to ensure proper alignment of normalization and parameter dimensions.


          fix layernorm grad sbp

4476fa4

ShawnXuan requested a review from fpzh2011

November 10, 2024 12:29

fpzh2011 approved these changes

View reviewed changes

ShawnXuan merged commit dfe78fb into layer_norm_grad_npu

11 of 21 checks passed

ShawnXuan deleted the fix_ln_grad_sbp branch

November 11, 2024 02:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet