Skip to content

Add few suppressions in order to silence the IDE#23248

Open
noordawod wants to merge 2 commits intoOpenAPITools:masterfrom
noordawod:feature/suppress-ide-warnings
Open

Add few suppressions in order to silence the IDE#23248
noordawod wants to merge 2 commits intoOpenAPITools:masterfrom
noordawod:feature/suppress-ide-warnings

Conversation

@noordawod
Copy link
Contributor

@noordawod noordawod commented Mar 14, 2026

The IDE keeps shouting about some pesky warnings that can be safely suppressed for the generated files. For example, redundant : Unit return value, redundant someString.toString() conversions, classes having empty { }, etc.

This PR adds these suppressions to have the code more self-aware.

Note: The only Mustache file that changed is licenseInfo.mustache.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) @dennisameling (2026/02)


Summary by cubic

Silences IDE warnings in Kotlin-generated sources by expanding @file:Suppress entries. Updates the Kotlin client template and regenerates samples; no behavior change.

  • Refactors
    • Adds suppression rules in kotlin-client/licenseInfo.mustache for DuplicatedCode, RemoveRedundantCallsOfConversionMethods/REDUNDANT_CALL_OF_CONVERSION_METHOD, RedundantUnitReturnType, RemoveEmptyClassBody, UnnecessaryVariable, UnusedImport, and unused.
    • Regenerates Kotlin sample clients and models so each file includes the new suppressions.

Written for commit 45b92d3. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 395 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@noordawod noordawod force-pushed the feature/suppress-ide-warnings branch from f643b77 to 45b92d3 Compare March 14, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant