Skip to content

PHP Generator: address PSR-12 formatting violations#23250

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
gcatanese:feat/postman-folder-description-and-php-psr12
Mar 15, 2026
Merged

PHP Generator: address PSR-12 formatting violations#23250
wing328 merged 2 commits intoOpenAPITools:masterfrom
gcatanese:feat/postman-folder-description-and-php-psr12

Conversation

@gcatanese
Copy link
Contributor

@gcatanese gcatanese commented Mar 14, 2026

This pull request refactors the ObjectSerializer Mustache template to avoid generating code that is not aligned to PSR-12 guidelines.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)


Summary by cubic

Align PHP generator output with PSR-12 by cleaning up formatting in the ObjectSerializer template. This keeps generated clients lint-clean without changing behavior.

  • Refactors
    • Standardize casting, foreach spacing, and add braces to single-line if statements.
    • Replace hash comments with slashes and fix docblock indentation.
    • Tidy query helpers: correct deepObject flattening prop assignment and guard returns with braces.
    • Normalize \DateTime checks and spacing in query value handling.
    • Regenerate PHP samples to reflect the template updates.

Written for commit 8c3059e. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@gcatanese gcatanese changed the title Postman Generator: address PSR-12 formatting violations PHP Generator: address PSR-12 formatting violations Mar 14, 2026
@wing328 wing328 added this to the 7.21.0 milestone Mar 15, 2026
@wing328 wing328 merged commit 25fab41 into OpenAPITools:master Mar 15, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants