Skip to content

webdav show error text below textfiels #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Conversation

Elelan
Copy link

@Elelan Elelan commented Mar 27, 2025

InternetArchiveLoginScreen cursor color in dark mode

InternetArchiveLoginScreen cursor color in dark mode
@Elelan Elelan self-assigned this Mar 27, 2025
@@ -213,7 +216,7 @@
private fun metadataHeader(): Headers {
return Headers.Builder()
.add("x-amz-auto-make-bucket", "1")
.add("x-archive-meta-language", "eng") // FIXME set based on locale or selected
.add("x-archive-meta-language", "eng") // TODO: FIXME set based on locale or selected

Check warning

Code scanning / detekt

Flags a forbidden comment. Warning

Forbidden TODO todo marker in comment, please do the changes.
@Elelan Elelan marked this pull request as ready for review March 27, 2025 07:28
@@ -168,13 +168,13 @@

binding.overlayContainer.show()
binding.progress.show()
binding.progressText.show()
//binding.progressText.show()

Check warning

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space after //

// Make sure to keep spinning until the upload has made some noteworthy progress.
if (progressValue > 2) {
binding.progress.setProgressCompat(progressValue, true)
}
binding.progressText.text = "${progressValue}%"
//binding.progressText.text = "${progressValue}%"

Check warning

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space after //
AppLogger.i("Updating progressText to $progressValue%")
binding.progressText.show(animate = true)
binding.progressText.text = "$progressValue%"
//AppLogger.i("Updating progressText to $progressValue%")

Check warning

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space after //
binding.progressText.show(animate = true)
binding.progressText.text = "$progressValue%"
//AppLogger.i("Updating progressText to $progressValue%")
//binding.progressText.show(animate = true)

Check warning

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space after //
binding.progressText.text = "$progressValue%"
//AppLogger.i("Updating progressText to $progressValue%")
//binding.progressText.show(animate = true)
//binding.progressText.text = "$progressValue%"

Check warning

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space after //
@Elelan Elelan merged commit 961cda9 into next Mar 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant