Skip to content

changed app colors to teal color from figma #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

changed app colors to teal color from figma #659

merged 3 commits into from
Mar 28, 2025

Conversation

Elelan
Copy link

@Elelan Elelan commented Mar 28, 2025

No description provided.

Elelan
Elelan commented Mar 28, 2025
View reviewed changes
Copy link
Author

@Elelan Elelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing color changes

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 28, 2025
View reviewed changes
...rchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginScreen.kt
containerColor = MaterialTheme.colorScheme.tertiary
containerColor = MaterialTheme.colorScheme.tertiary,
disabledContainerColor = colorResource(R.color.grey_50),
disabledContentColor = colorResource(R.color.extra_light_grey)//MaterialTheme.colorScheme.onBackground

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)
...rchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginScreen.kt
containerColor = MaterialTheme.colorScheme.tertiary
containerColor = MaterialTheme.colorScheme.tertiary,
disabledContainerColor = colorResource(R.color.grey_50),
disabledContentColor = colorResource(R.color.extra_light_grey)//MaterialTheme.colorScheme.onBackground

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
...rchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginScreen.kt
containerColor = MaterialTheme.colorScheme.tertiary
containerColor = MaterialTheme.colorScheme.tertiary,
disabledContainerColor = colorResource(R.color.grey_50),
disabledContentColor = colorResource(R.color.extra_light_grey)//MaterialTheme.colorScheme.onBackground

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Missing newline before ")"
...rchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginScreen.kt
containerColor = MaterialTheme.colorScheme.tertiary
containerColor = MaterialTheme.colorScheme.tertiary,
disabledContainerColor = colorResource(R.color.grey_50),
disabledContentColor = colorResource(R.color.extra_light_grey)//MaterialTheme.colorScheme.onBackground

Check warning

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space before //
...rchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginScreen.kt
containerColor = MaterialTheme.colorScheme.tertiary
containerColor = MaterialTheme.colorScheme.tertiary,
disabledContainerColor = colorResource(R.color.grey_50),
disabledContentColor = colorResource(R.color.extra_light_grey)//MaterialTheme.colorScheme.onBackground

Check warning

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space after //
...main/java/net/opendasharchive/openarchive/features/settings/CreativeCommonsLicenseManager.kt
@@ -69,8 +69,8 @@
tvLicenseUrl.text = currentLicense
tvLicenseUrl.styleAsLink()
swCcEnabled.isEnabled = enabled
swAllowRemix.isEnabled = enabled
swRequireShareAlike.isEnabled = enabled
swAllowRemix.isEnabled = enabled

Check warning

Code scanning / detekt

Reports multiple space usages Warning

Unnecessary long whitespace
@Elelan Elelan merged commit 082f23d into next Mar 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Elelan