-
Notifications
You must be signed in to change notification settings - Fork 26
fixed issue for server list empty state not showing correctly #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
viewModelOf(::SpaceListViewModel) |
Check warning
Code scanning / detekt
Reports consecutive blank lines Warning
@@ -36,8 +36,15 @@ | |||
|
|||
binding.composeViewSpaceList.setContent { | |||
|
|||
val viewModel: SpaceListViewModel = koinViewModel() |
Check warning
Code scanning / detekt
Reports multiple space usages Warning
|
||
class SpaceListViewModel() : ViewModel() { |
Check warning
Code scanning / detekt
Reports consecutive blank lines Warning
class SpaceListViewModel() : ViewModel() { | ||
|
||
private val _spaceList = MutableStateFlow<List<Space>>(emptyList()) | ||
val spaceList: StateFlow<List<Space>> = _spaceList | ||
|
||
fun refreshSpaces() { | ||
_spaceList.value = Space.getAll().asSequence().toList() | ||
} | ||
} |
Check warning
Code scanning / detekt
Library classes should not be public. Warning
import org.koin.androidx.compose.koinViewModel | ||
|
||
|
||
class SpaceListViewModel() : ViewModel() { |
Check warning
Code scanning / detekt
If a source file contains only a single non-private top-level class or object, the file name should reflect the case-sensitive name plus the .kt extension. Warning
import org.koin.androidx.compose.koinViewModel | ||
|
||
|
||
class SpaceListViewModel() : ViewModel() { |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed. Warning
No description provided.