Skip to content

fixed a crash where app crashed when trying to add IA account without internet #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

Elelan
Copy link

@Elelan Elelan commented May 2, 2025

No description provided.

@@ -72,8 +74,10 @@
import net.opendasharchive.openarchive.features.internetarchive.presentation.components.InternetArchiveHeader
import net.opendasharchive.openarchive.features.internetarchive.presentation.login.InternetArchiveLoginAction.CreateLogin
import net.opendasharchive.openarchive.features.internetarchive.presentation.login.InternetArchiveLoginAction.Login
import net.opendasharchive.openarchive.features.internetarchive.presentation.login.InternetArchiveLoginAction.LoginError

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import
import android.net.NetworkCapabilities

object NetworkUtils {
fun isNetworkAvailable(context: Context): Boolean {

Check warning

Code scanning / detekt

Restrict the number of return statements in methods. Warning

Function isNetworkAvailable has 3 return statements which exceeds the limit of 2.
@Elelan Elelan merged commit 8951809 into next May 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant