Skip to content

Removed "Tor is disabled" pop-up #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

Elelan
Copy link

@Elelan Elelan commented Jun 10, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 10, 2025 13:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the informational pop-up that appeared when Tor was disabled in the settings screen.

  • Deleted dialog block that showed “Tor is disabled” message.
  • Settings UI now only updates visibility and text without an interruptive modal.
Comments suppressed due to low confidence (3)

app/src/main/java/net/opendasharchive/openarchive/features/settings/SettingsFragment.kt:180

  • Update or add unit/UI tests for SettingsFragment to ensure that no dialog appears when Tor is disabled.
if (enabled) {

app/src/main/java/net/opendasharchive/openarchive/features/settings/SettingsFragment.kt:178

  • [nitpick] Consider adding a non-blocking notification (e.g., Snackbar) or inline message to inform users why Tor is disabled, so the change isn't silent.
setUseTorText(torViewModel.torStatus.value, enabled)

app/src/main/java/net/opendasharchive/openarchive/features/settings/SettingsFragment.kt:180

  • Add a comment or update project docs/changelog to explain why the Tor-disabled pop-up was removed and what the intended new UX is.
// Removed dialogManager.showDialog(...) block

@prathieshna prathieshna merged commit 8140b5d into next Jun 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants