Bug fix/settings screen tor button UI fix for dark mode #680
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates build tooling versions, bumps the app version code, and refines the settings screen UI for the Tor button to improve dark mode support.
- Bump Gradle wrapper, Android Gradle Plugin, Kotlin, and KSP versions
- Increment app
versionCodeto 30008 - Adjust preference XML and layout XML to customize the Tor switch and button styling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution URL to 8.14.2 |
| gradle/libs.versions.toml | Bumped AGP to 8.10.1, Kotlin to 2.1.21, and KSP to 2.1.21-2.0.1 |
| app/src/main/res/xml/prefs_general.xml | Refined SwitchPreferenceCompat and related preferences styling |
| app/src/main/res/layout/prefs_open_orbot.xml | Added margins, tints, and xmlns:app for the Tor button layout |
| app/build.gradle.kts | Incremented Android app versionCode |
| @@ -95,35 +95,40 @@ | |||
| android:title="Encrypt"> | |||
|
|
|||
| <SwitchPreferenceCompat | |||
| android:defaultValue="false" | |||
There was a problem hiding this comment.
SwitchPreferenceCompat should use app:defaultValue instead of android:defaultValue to ensure the support preference framework recognizes the default value.
| android:defaultValue="false" | |
| app:defaultValue="false" |
Copilot uses AI. Check for mistakes.
| @@ -95,35 +95,40 @@ | |||
| android:title="Encrypt"> | |||
|
|
|||
| <SwitchPreferenceCompat | |||
| android:defaultValue="false" | |||
| android:icon="@null" | |||
There was a problem hiding this comment.
[nitpick] Duplicate null icon declarations exist (android:icon and app:icon). Remove one (preferably android:icon) for consistency with PreferenceCompat attributes.
| android:icon="@null" |
Copilot uses AI. Check for mistakes.
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginBottom="@dimen/activity_vertical_margin" | ||
| android:backgroundTint="@color/colorTertiary" |
There was a problem hiding this comment.
[nitpick] You have both android:backgroundTint and app:backgroundTint on the Button. Choose one namespace to avoid duplication and potential styling conflicts.
| android:backgroundTint="@color/colorTertiary" |
Copilot uses AI. Check for mistakes.
…n prefs_general.xml
No description provided.