Skip to content

Agent will install even if sysetmd is in degraded mode #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/current
Choose a base branch
from

Conversation

Albert-LGTM
Copy link

Proposed changes

  • The OpenBAS agent install fails if Systemd is in degraded mode. This mode occurs if one or more (unrelated) systemd services failed to start.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Copy link
Contributor

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Albert-LGTM, good thinking! Thanks for your contribution.

As a policy, we require pgp-signed commits for inclusion into the repository, would you consider amending the PR to sign the commits?

Apart from that, it looks like this change should be replicated in the other linux-specific -installer and -upgrade scripts.

@Albert-LGTM
Copy link
Author

I have now renamed the variable to systemd_status and updated every agent linux script to accept systemd in degraded mode

@Albert-LGTM Albert-LGTM requested a review from antoinemzs June 5, 2025 12:41
@antoinemzs antoinemzs changed the base branch from main to release/current June 5, 2025 13:46
@antoinemzs
Copy link
Contributor

That's great, thanks. We'll get on that ASAP, and keep you posted.

@antoinemzs antoinemzs self-assigned this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants