[nuclei/nmap] Improve & fix contracts #78
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumejparis
force-pushed
the
improvment/contracts_mandatory_fields
branch
from
75697b6 to
989fc2d
Compare
nmap/nmap/openbas_nmap.py
Outdated
| @@ -38,7 +38,7 @@ def __init__(self): | |||
| }, | |||
| ) | |||
| self.helper = OpenBASInjectorHelper( | |||
| self.config, open("img/icon-nmap.png", "rb") | |||
| self.config, open("nmap/img/nmap.png", "rb") | |||
There was a problem hiding this comment.
Why do you want to change the path here ?
There was a problem hiding this comment.
This path would be based on the expected relative path from the python process own working directory. Given the docker file hasn't been changed, I do not recommend changing the path.
Generally we would like to reformat the inner projects (individual injectors) to match what's been done for Nuclei, but that looks out of scope for this PR.
antoinemzs
requested changes
Jun 16, 2025
guillaumejparis
force-pushed
the
improvment/contracts_mandatory_fields
branch
from
989fc2d to
974ed8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments