Skip to content

[frontend] fix quickinject component to allow quick email in running simulation (#3453) #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/current
Choose a base branch
from

Conversation

antoinemzs
Copy link
Contributor

Proposed changes

  • Fix component setup for Quick inject

Testing Instructions

  1. Set up a simulation and have it running
  2. Go to Animation, "Mails" tab
  3. Create a new email
  4. Drawer pulls up and allows for creating a quick email inject

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@antoinemzs antoinemzs linked an issue Jul 16, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.41%. Comparing base (adc7a88) to head (4fe3c4a).

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #3643      +/-   ##
=====================================================
+ Coverage              44.40%   44.41%   +0.01%     
  Complexity              2799     2799              
=====================================================
  Files                    762      762              
  Lines                  23138    23138              
  Branches                1610     1610              
=====================================================
+ Hits                   10274    10277       +3     
+ Misses                 12289    12286       -3     
  Partials                 575      575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an email during a running simulation no longer works
1 participant