Skip to content

[frontend] Fix pdf export on firefox (#3443) #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guillaumejparis
Copy link
Member

Proposed changes

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jul 17, 2025
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.40%. Comparing base (f211bb5) to head (6645493).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3650   +/-   ##
=========================================
  Coverage     44.40%   44.40%           
  Complexity     2799     2799           
=========================================
  Files           762      762           
  Lines         23138    23138           
  Branches       1610     1610           
=========================================
  Hits          10274    10274           
  Misses        12289    12289           
  Partials        575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antoinemzs
Copy link
Contributor

@guillaumejparis can you write a short summary of what you've done in this patch, because it's rather obscure. What was fixed and how did you reach the solution? It'll be useful for later, for when we have to fix it again. I assume this makes upgrading the original lib difficult because we have to work out a patch every time. Correct?

@antoinemzs
Copy link
Contributor

antoinemzs commented Jul 17, 2025

We should also not just swallow the clientside exception, please could you take the opportunity to rethrow to catch later or at least call console.error() to show the error in the console.

.catch(() => {
MESSAGING$.notifyError(t('An error occurred during PDF generation.'));
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF export of report is not working
3 participants