feat: add option to import OBK *.json layout file #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mominul
reviewed
Nov 2, 2023
src/frontend/LayoutConverter.cpp
Outdated
| if (QJsonDocument::fromJson(jsonFile.readAll()).object() | ||
| .value("info").toObject() | ||
| .value("version").toString() != "2") { | ||
| return UnsupportedLayout; |
There was a problem hiding this comment.
How about using the LayoutConverter::convertLayoutFormat() function here to perform the conversion if we detect an old layout version (version 1)?
There was a problem hiding this comment.
I wasn't sure if the old version had the same schema, it turns out it had, just updated the code to handle version 1.
|
Thanks a lot, @NabilSnigdho! ❤️ I have made a comment, please address that 😄 |
|
Thanks again! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #345, this adds option to import OBK *.json layout file.
Support for version 1 layout format is not added.