Skip to content

Hjson #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2016
Merged

Hjson #40

merged 2 commits into from
Nov 5, 2016

Conversation

kristovatlas
Copy link
Member

This change improves readability and reduces the line counts from from
around 2700 lines to around 2000.

QA:

  1. Verified that the Hjson validates:
$ python validate_json.py obpp3.hjson
'obpp3.hjson' matches the specified schema.
  1. Ran JSON and Hjson versions through docgen.py and confirmed that
    they render to the same file by copying the rendered markdown in Typora
    and comparing the pasted plaintext version.

This change improves readability and reduces the line counts from from
around 2700 lines to around 2000.

QA:

1) Verified that the Hjson validates:
```
$ python validate_json.py obpp3.hjson
'obpp3.hjson' matches the specified schema.
```

2) Ran JSON and Hjson versions through `docgen.py` and confirmed that
they render to the same file by copying the rendered markdown in Typora
and comparing the pasted plaintext version.
@dcousens
Copy link

dcousens commented Nov 5, 2016

ACK

@kristovatlas kristovatlas merged commit c9a77e5 into reorg-to-scoring-system Nov 5, 2016
@kristovatlas kristovatlas deleted the hjson branch November 5, 2016 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants