Schema criteria or criteria groups #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a countermeasure Also updated the threat model example by removing encapsulating “criteria-groups” from criteria when there was not more than one group. QA: 1. All unit tests pass: ``` $ ./run_quick_test.sh .............. ---------------------------------------------------------------------- Ran 14 tests in 0.066s OK ``` 2. Verified that example JSON validates: ``` $ python validate_json.py "threat model example.json" 'threat model example.json' matches the specified schema. ``` 3. Verified that markdown generated by docgen is the same as it was before after being rendered by markdown app Typora and comparing the pasted text.
kristovatlas
added this to the
v1.0.0 -- used for OBPP threat model v3 final product milestone
added 2 commits
November 5, 2016 16:38
Only 5 criteria groups remain, used to separate mutually exclusive criteria. QA: 1. Verified that Hjson still validates: ``` $ python validate_json.py "obpp3.hjson" 'obpp3.hjson' matches the specified schema. ``` 2. Compared pasted plaintext of rendered markdown before and after to verify they are identical.
|
LGTM |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the schema and working obpp3 model to remove unnecessary “criteria-groups” arrays that enclose criteria when there was previously only one group present.