Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple Dockerfile and docker-compose file #1

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Totto16
Copy link
Contributor

@Totto16 Totto16 commented Jan 18, 2024

This adds a Dockerfile and docker-compose.yml file, the README describes how to use them

fix two flask errors:

#  * Ignoring a call to 'app.run()' that would block the current 'flask' CLI command.
#    Only call 'app.run()' in an 'if __name__ == "__main__"' guard.

fix it, by checking, if the file is called directly or by imported by flask

WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead. so I use the suggested package by flask itself

Copy link
Contributor

@mgerhold mgerhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need docker containers at this point, but thanks for your efforts, this might come in handy at a later point in time.

@Totto16 Totto16 marked this pull request as draft January 20, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants