Improve recording utility #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add json serializer, atm only to_json is implemented - use static version constant instead of hardcoded magic value for recording file version
|
Code Coverage SummaryResults for commit: ba7b483 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
- be subproject agnostic (e.g,. this project can be used as subproject) - override teh declared dependencies, so that it's easier to use those dependencies elsewhere
- fix a few meson things
- radically change the structure of the whole game so that it: - can be used as dependency - is subproject agnsotic - installs headers correctly - generates correct package files - make include files all use correct headers, so that they work when installed - remove helper helper::optional, since every compiler we support supports std::optional WIP
…ws.h", so everything that includes "api.hpp" needs to do that, even if it sucks, since header order shouldn't matter, but it does on windows xD
…ded automatically, by providing liboopetris_core - now fmt works with clang, so not using header only lib anymore
…from supported node versions
…x it by specifying a flag, to disable a gcc-14 warning
- add the NOMINMAX hack (I hate windows.h xD) - fix building with many hacks in the bindings.py - fix compilation in CI, since we have to use static stdlib
- fix Ci, by using libcpp in macos build - fix binding.gyp build on mac
- wrap all main functions in a try catch, to print the exception message - replace all usage of helper::expected<bool, T> with helper::expected<void, T>, where only true is used as teh state of the bool, just to signify .has_value()
…at may be replaced by "#define main SDL_main" and doesn't like the noexcept attribute
…:exit() doesn't work, so trowing an exception, catching it in the main a,dn exiting via return there - core/errors.hpp: add virtual override for std::exception what(), so that it gets a correct message, if it's used wrongly
…to be removed from an internal array due to not using JoystickLikeInput but JoystickInput
- remove service_provider member from MusicManager, it is not needed - android handle a few special events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failures on the Windows Wrapper Ci are related to prebuild/prebuildify#90
and are fixed by prebuild/prebuildify#91
solved by uploading it to the private package registry here