-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for BSS to perform client credentials grant for access token #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidallendj
added
enhancement
New feature or request
not ready
Not ready to merge
needs testing
labels
Feb 28, 2024
This was referenced Feb 28, 2024
@synackd Can you test this with the deployment recipes and see if it prints an access token? |
synackd
requested changes
Feb 28, 2024
davidallendj
changed the title
[DRAFT] Add ability for BSS to perform client credentials grant for access token
Add ability for BSS to perform client credentials grant for access token
Feb 29, 2024
Add flag and environment variable for OAUTH2 server
Sometimes the endpoint isn't ready right away, and testing at intervals avoids BSS crashing because of it.
Add JWT verification and use JWT with SMD
synackd
approved these changes
Mar 8, 2024
synackd
reviewed
Mar 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives BSS the ability to create an OAuth client, register it with an authorization server (presumably Ory Hydra currently), and fetch a token using client credentials received from registration (i.e. client credentials grant). This PR is necessary for BSS to make requests to other microservices, such as SMD, for public endpoints that do not require the user to submit an access token, such as
/boot/v1/bootscript
, which would cause the request to fail.