Skip to content

test: Add failing test to demonstrate bug in csv-table-no-translate #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

jpmckinney
Copy link
Contributor

@jpmckinney jpmckinney commented May 22, 2025

@duncandewhurst You'll need to find a way to get this test to pass.

Excerpt of the test failure in GitHub Actions:

    <p>
    A <a class="reference internal" href="other.html#heading-1">
    <span class="std std-ref">
  - reference</span>
  + </span>
    </a>
    </p>

@jpmckinney
Copy link
Contributor Author

Ok, think I fixed it.

@duncandewhurst
Copy link

Fantastic, thank you!

@jarofgreen
Copy link
Contributor

This looks good but can we have an associated Changelog entry?

Does this cover it? "Ensure links (markdown and sphinx :ref:) are rendered properly in csv-table-no-translate"

@jpmckinney
Copy link
Contributor Author

Looks good

@jarofgreen
Copy link
Contributor

Any chance you can add it to your branch? Then I can approve and merge faster. If I add it I'll have to find someone else here to approve.

@jpmckinney
Copy link
Contributor Author

Done

@jarofgreen jarofgreen merged commit 370d66d into OpenDataServices:main May 22, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants